Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

leadership: pause and unpause workers consistently #8089

Merged
merged 2 commits into from
Jun 4, 2020

Conversation

notnoop
Copy link
Contributor

@notnoop notnoop commented Jun 1, 2020

This fixes a bug where leadership establishment pauses 3/4 of workers
but stepping down unpause only 1/2!

The test fails initially in https://circleci.com/gh/hashicorp/nomad/73154 but passes with the fix in latest revision.

Mahmood Ali added 2 commits June 1, 2020 10:48
This fixes a bug where leadership establishment pauses 3/4 of workers
but stepping down unpause only 1/2!
@notnoop notnoop added this to the 0.11.3 milestone Jun 1, 2020
@notnoop notnoop requested a review from schmichael June 1, 2020 15:30
@notnoop notnoop self-assigned this Jun 1, 2020
@notnoop notnoop requested a review from shoenig June 3, 2020 14:25
@notnoop notnoop merged commit 192b7e8 into master Jun 4, 2020
@notnoop notnoop deleted the b-leader-worker-count branch June 4, 2020 16:01
notnoop pushed a commit that referenced this pull request Jun 4, 2020
leadership: pause and unpause workers consistently
@github-actions
Copy link

github-actions bot commented Jan 3, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants